Add Subtitulamos provider integration #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrcnull
reviewed
Sep 22, 2024
|
Thanks for updating this provider! Don't worry too much about mypy (or if you need help let me know). It's better if coverage is high ;) |
…3.8 compatibility
getzze
reviewed
Oct 22, 2024
# Conflicts: # tests/providers/test_providers.py
…noamérica)' support adding all countries
getzze
reviewed
Nov 11, 2024
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Subtitulamos provider
This PR is partially based and replaces #826 (skipping the provider "tusubtitulo" as is not working anymore)
Also I added a way to run the cli from source code (subliminal/cli.py#L727-L728) , as is helpful to debug new additions (if you don't like it, tell me and I'll remove it)Pending: